Extract plugins for yarn and ruby to separate responsibilities #87
Conversation
xjunior
force-pushed
the
hfh/plugin-system
branch
7 times, most recently
from
058a4bd to
5ecaa00
Compare
xjunior
force-pushed
the
hfh/plugin-system
branch
4 times, most recently
from
d214742 to
68e670a
Compare
xjunior
force-pushed
the
hfh/plugin-system
branch
from
f4837f3 to
7c9b094
Compare
xjunior
force-pushed
the
hfh/plugin-system
branch
2 times, most recently
from
c53155a to
c4b8c4f
Compare
xjunior
force-pushed
the
hfh/plugin-system
branch
from
fb47fde to
c3d2548
Compare
xjunior
changed the title
| @@ -0,0 +1,6 @@ | |||
| module CobraCommander | |||
| module Ruby | |||
| VERSION: String | |||
There was a problem hiding this comment.
Plan on setting types for other files?
| def [](key) | ||
| Class.new(self) do | ||
| define_singleton_method(:key) { key } | ||
| define_method(:key) { key } | ||
|
|
||
| def self.inherited(base) | ||
| super | ||
| superclass.all[key] = base | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
I'm going to have to open a console in here to unpack what this accomplishes. I wasn't familiar with Forwardable.
What is key? Is it a name or a path, or what?
There was a problem hiding this comment.
Yeah, I'm not a big fan of how this is right now, but what it achieves is:
I want a class extending the registry to be registered in the registry and have a key attribute used to identify the registered class uniquely within the registry. This key is used to toggle the plugin on/off in the, for instance.
The key is a required class attribute of the source, so I didn't want to just have them define a key, I wanted to initialize it with the inheritance. This is the best I could do.
This defines a class with a key, and once inherited it will register the new class with the given key. The resulting syntax is similar to what AR does with migrations. I wish the code was simpler, but I like the overall solution.
There was a problem hiding this comment.
Is it a category then perhaps? Or possibly a klass? --- Maybe even just a registration_key?
This PR splits CobraCommander into three packages:
cobra_commander: the core models of a cobra app (components and umbrella), the CLI, and tools such as graph, tree, and the executorcobra_commander-ruby: the source for ruby packages within a cobra appcobra_commander-yarn: the source for JS/yarn workspaces packages within a cobra appWith this change, a cobra app should now include the core library and the necessary plugins within the
cobrabundle group.The plugins should gain extra responsibility in the near future, like the introduction of Cobra Generators and dependency management (add/remove)
Todo