Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse umbrella#resolve in affected #91

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Reuse umbrella#resolve in affected #91

merged 2 commits into from
Nov 9, 2022

Conversation

xjunior
Copy link
Contributor

@xjunior xjunior commented Nov 9, 2022

  • Resolve nested files in Umbrella#resolve
  • Refactor affected to use json only on to_json

@xjunior xjunior force-pushed the refactor-affected-resolve branch from e88a653 to 23ba052 Compare November 9, 2022 04:00
@xjunior xjunior enabled auto-merge (squash) November 9, 2022 04:02
garettarrowood
garettarrowood approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@garettarrowood garettarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xjunior xjunior merged commit a66ab23 into main Nov 9, 2022
@xjunior xjunior deleted the refactor-affected-resolve branch November 9, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garettarrowood garettarrowood garettarrowood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xjunior @garettarrowood