Fail execution when a command fails

cobra_commander/lib/cobra_commander/cli.rb

@@ -49,9 +49,10 @@ def exec(script_or_components, script = nil)
         components_filtered(script && script_or_components),
         script || script_or_components
       )
-      CobraCommander::Executor.execute(jobs: jobs, workers: options.concurrency,
-                                       output_mode: options.interactive && jobs.count > 1 ? :interactive : :markdown,
-                                       output: $stdout, status_output: $stderr)
+      output_mode = options.interactive && jobs.count > 1 ? :interactive : :markdown
+      execution = CobraCommander::Executor.execute(jobs: jobs, workers: options.concurrency,
+                                                   output_mode: output_mode, output: $stdout, status_output: $stderr)
+      exit 1 unless execution.success?
     end
 
     desc "cmd [components] <command>", "Executes the command in the context of a given component or set thereof. " \
@@ -68,9 +69,10 @@ def cmd(command_or_components, command = nil)
         components_filtered(command && command_or_components),
         command || command_or_components
       )
-      CobraCommander::Executor.execute(jobs: jobs, workers: options.concurrency,
-                                       output_mode: options.interactive && jobs.count > 1 ? :interactive : :markdown,
-                                       output: $stdout, status_output: $stderr)
+      output_mode = options.interactive && jobs.count > 1 ? :interactive : :markdown
+      execution = CobraCommander::Executor.execute(jobs: jobs, workers: options.concurrency,
+                                                   output_mode: output_mode, output: $stdout, status_output: $stderr)
+      exit 1 unless execution.success?
     end
 
     desc "tree [component]", "Prints the dependency tree of a given component or umbrella"

cobra_commander/lib/cobra_commander/executor/execution.rb

@@ -17,11 +17,19 @@ def initialize(jobs, workers:)
         merge! create_futures(jobs)
       end
 
+      # Wait for all jobs to complete, returns a future with all execution futures
+      # @return [Concurrent::Promises::Future]
       def wait
         Concurrent::Promises.zip_futures_on(@executor, *values)
                             .tap(&:wait)
       end
 
+      # The execution succeeds when all jobs succeeded
+      # @return [Boolean]
+      def success?
+        values.all?(&:fulfilled?)
+      end
+
     private
 
       def create_future(job)

cobra_commander/lib/cobra_commander/umbrella.rb

@@ -75,8 +75,7 @@ def resolve(path)
     #
     #      umbrella.load(ruby: true)
     #
-    # @param path [String,Pathname] the path to be resolved
-    # @return [::CobraCommander::Component,nil] the component where the path is
+    # @see CobraCommander::Registry
     #
     def load(**source_selector)
       Source.load(path, config["sources"], **source_selector).flatten.each do |package|

cobra_commander/spec/cobra_commander/cli_spec.rb

@@ -71,6 +71,7 @@
     it "errors gently if component doesn't exist" do
       run_command_and_stop("cobra cmd --no-interactive -a #{umbrella.path} non_existent pwd", fail_on_error: false)
 
+      expect(last_command_started).to_not be_successfully_executed
       expect(last_command_output).to match(/Component non_existent not found/)
     end
 
@@ -89,6 +90,14 @@
 
       expect(last_command_output).to include("install memory deps")
     end
+
+    it "exists with error when a job fails" do
+      run_command_and_stop("cobra cmd --no-interactive -a #{umbrella.path} --memory " \
+                           "--dependents directory failing_command",
+                           fail_on_error: false)
+
+      expect(last_command_started).to_not be_successfully_executed
+    end
   end
 
   describe "cobra graph" do

cobra_commander/spec/fixtures/app/cobra.yml

@@ -4,4 +4,5 @@ sources:
       deps: "echo 'install stub deps'"
   :memory:
     commands:
+      failing_command: "lol"
       deps: "echo 'install memory deps'"