-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PLAY-1751] Convert Kits to Use pb_content_tag (File Upload, Filter, …
…Form Group, and Form Pill) (#4153) **What does this PR do?** A clear and concise description with your runway ticket url. Update File Upload, Filter, Form Group, and Form Pill kits to no longer use "content_tag" and use our new "pb_content_tag". **How to test?** Steps to confirm the desired behavior: 1. Test Rails File Upload, Filter, Form Group, and Form Pill kits on Playbook website. 2. Test uses on Nitro. #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review.
- Loading branch information
Showing
4 changed files
with
4 additions
and
18 deletions.
There are no files selected for viewing
7 changes: 1 addition & 6 deletions
7
playbook/app/pb_kits/playbook/pb_file_upload/file_upload.html.erb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 1 addition & 6 deletions
7
playbook/app/pb_kits/playbook/pb_form_group/form_group.html.erb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,3 @@ | ||
<%= content_tag(:div, | ||
aria: object.aria, | ||
class: object.classname, | ||
data: object.data, | ||
id: object.id, | ||
**combined_html_options) do %> | ||
<%= pb_content_tag(:div) do %> | ||
<%= content.presence %> | ||
<% end %> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters