Let bundler manage LOAD_PATH #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundler should add the correct LOAD_PATH based on each Gemfile. When we manipulate the LOAD_PATH like that we end adding dependencies to it that are not declared. This happens because Bundler will parse and execute all the gemspecs in a source (`source ".." do`), even when it ends up ignorign it.
xjunior
force-pushed
the
fix-load-path
branch
from
f00032a to
37f7e6a
Compare
that-jill
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundler should add the correct LOAD_PATH based on each Gemfile.
When we manipulate the LOAD_PATH like that, we add undeclared dependencies to it. This happens because Bundler will parse and execute all the
gemspecs in a source, even when it ends up ignoring it.