Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce edgestitch #61

Merged
merged 33 commits into from
Dec 27, 2022
Merged

Introduce edgestitch #61

merged 33 commits into from
Dec 27, 2022

Conversation

xjunior
Copy link
Contributor

@xjunior xjunior commented Dec 21, 2022

Edgestitch is a rethought approach to the db:stitch tasks extracted from nitro. While in nitro, the process was to form the structure.sql from the structure-self.sql of components that the target component depends on, using cobra to discover this dependency tree.

This new approach finds all loaded Engines, and puts together their structure-self.sql to form a new structure.sql, allowing external engines also to provide and own tables. The end result is the same, without the CobraCommander overhead.

@xjunior xjunior marked this pull request as ready for review December 22, 2022 17:48
@xjunior xjunior requested a review from a team as a code owner December 22, 2022 17:48
Copy link
Contributor

@that-jill that-jill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of questions, overall I like it a lot

packages/edgestitch/docs/README.md Outdated Show resolved Hide resolved
packages/edgestitch/docs/README.md Show resolved Hide resolved
packages/edgestitch/docs/README.md Outdated Show resolved Hide resolved
packages/edgestitch/docs/README.md Outdated Show resolved Hide resolved
packages/edgestitch/docs/README.md Show resolved Hide resolved
packages/edgestitch/lib/edgestitch/version.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@that-jill that-jill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@xjunior xjunior merged commit 81a6ea3 into main Dec 27, 2022
@xjunior xjunior deleted the edgestitch branch December 27, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants