Remove default rails 5.2 support #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmfvpereira
pushed a commit
that referenced
this pull request
Jan 19, 2023
* Remove default rails 5.2 support * Limit rails support to what we test Signed-off-by: Gabriel Pereira <gabriel.pereira@powerhrg.com>
gmfvpereira
added a commit
that referenced
this pull request
Jan 30, 2023
This reverts commit 037009f.
that-jill
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Remove default rails 5.2 support (#62) * Remove default rails 5.2 support * Limit rails support to what we test Signed-off-by: Gabriel Pereira <gabriel.pereira@powerhrg.com> * Add prettier as eslint-config dep Signed-off-by: Gabriel Pereira <gabriel.pereira@powerhrg.com> * Run prettier --write on eslint Signed-off-by: Gabriel Pereira <gabriel.pereira@powerhrg.com> * Export prettier config Signed-off-by: Gabriel Pereira <gabriel.pereira@powerhrg.com> * Run prettier on Github checks Signed-off-by: Gabriel Pereira <gabriel.pereira@powerhrg.com> * Don't encourage overrides Signed-off-by: Gabriel Pereira <gabriel.pereira@powerhrg.com> * Update documentations to include JS examples Signed-off-by: Gabriel Pereira <gabriel.pereira@powerhrg.com> * Improve package's doc to include Prettier Signed-off-by: Gabriel Pereira <gabriel.pereira@powerhrg.com> * Add missing extra line Co-authored-by: Ben Langfeld <ben@langfeld.me> Signed-off-by: Gabriel Pereira <gabriel.pereira@powerhrg.com> * Fix prettier offense on Readme Signed-off-by: Gabriel Pereira <gabriel.pereira@powerhrg.com> * Add eslint-config-prettier to ignore conflicting rules Adds the lib as a dependency so that clients can run `yarn eslint-config-prettier path/to/main.js` to check rules. * Add doc on how to spot conflicting rules * Run prettier on doc * Revert "Remove default rails 5.2 support (#62)" This reverts commit 037009f. --------- Signed-off-by: Gabriel Pereira <gabriel.pereira@powerhrg.com> Co-authored-by: Carlos Palhares <chjunior@gmail.com> Co-authored-by: Ben Langfeld <ben@langfeld.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove default support for rails 5.2 given all apps are now rails 6+