Support .ttc files #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing a .ttc file with multiple embedded fonts, it patches all of them and generates a new .ttc. Presumably the added symbols won't look right in the non-Regular variants, but it's better than omitting them. This has not been tested on non-TTC fonts. I assume that they'll only contain one font, which means they'll behave as expected.
2 tasks
Finii
added a commit
to ryanoasis/nerd-fonts
that referenced
this pull request
Feb 9, 2022
[why] Someone might want to patch a whole lot of fonts that come in a ttc. [how] Just open all fonts that the input file contains (1 or more) and create a single font or collection font file. The automatic layer detection does not work in all cases for me, so we need to manually search for the foreground layer (usually '1'). Code inspiration taken from powerline/fontpatcher#6 [note] Changed output in the end to the filename (before it was the font name), so that one can easily copy&paste or open that file. Reported-by: Lily Ballard <lily@ballards.net> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
to ryanoasis/nerd-fonts
that referenced
this pull request
Feb 9, 2022
[why] Someone might want to patch a whole lot of fonts that come in a ttc. [how] Just open all fonts that the input file contains (1 or more) and create a single font or collection font file. The automatic layer detection does not work in all cases for me, so we need to manually search for the foreground layer (usually '1'). Code inspiration taken from powerline/fontpatcher#6 [note] Changed output in the end to the filename (before it was the font name), so that one can easily copy&paste or open that file. Reported-by: Lily Ballard <lily@ballards.net> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
to ryanoasis/nerd-fonts
that referenced
this pull request
Feb 9, 2022
[why] Someone might want to patch a whole lot of fonts that come in a ttc. [how] Just open all fonts that the input file contains (1 or more) and create a single font or collection font file. The automatic layer detection does not work in all cases for me, so we need to manually search for the foreground layer (usually '1'). Code inspiration taken from powerline/fontpatcher#6 [note] Changed output in the end to the filename (before it was the font name), so that one can easily copy&paste or open that file. Reported-by: Lily Ballard <lily@ballards.net> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
2 tasks
Finii
added a commit
to ryanoasis/nerd-fonts
that referenced
this pull request
Feb 9, 2022
[why] Someone might want to patch a whole lot of fonts that come in a ttc. [how] Just open all fonts that the input file contains (1 or more) and create a single font or collection font file. The automatic layer detection does not work in all cases for me, so we need to manually search for the foreground layer (usually '1'). Code inspiration taken from powerline/fontpatcher#6 [note] Changed output in the end to the filename (before it was the font name), so that one can easily copy&paste or open that file. Reported-by: Lily Ballard <lily@ballards.net> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
to ryanoasis/nerd-fonts
that referenced
this pull request
Sep 14, 2022
[why] Someone might want to patch a whole lot of fonts that come in a ttc. [how] Just open all fonts that the input file contains (1 or more) and create a single font or collection font file. The automatic layer detection does not work in all cases for me, so we need to manually search for the foreground layer (usually '1'). Code inspiration taken from powerline/fontpatcher#6 [note] Changed output in the end to the filename (before it was the font name), so that one can easily copy&paste or open that file. Reported-by: Lily Ballard <lily@ballards.net> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
to ryanoasis/nerd-fonts
that referenced
this pull request
Sep 23, 2022
[why] Someone might want to patch a whole lot of fonts that come in a ttc. [how] Just open all fonts that the input file contains (1 or more) and create a single font or collection font file. The automatic layer detection does not work in all cases for me, so we need to manually search for the foreground layer (usually '1'). Code inspiration taken from powerline/fontpatcher#6 [note] Changed output in the end to the filename (before it was the font name), so that one can easily copy&paste or open that file. Reported-by: Lily Ballard <lily@ballards.net> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
[why] Someone might want to patch a whole lot of fonts that come in a ttc. [how] Just open all fonts that the input file contains (1 or more) and create a single font or collection font file. The automatic layer detection does not work in all cases for me, so we need to manually search for the foreground layer (usually '1'). Code inspiration taken from powerline/fontpatcher#6 [note] Changed output in the end to the filename (before it was the font name), so that one can easily copy&paste or open that file. Reported-by: Lily Ballard <lily@ballards.net> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing a .ttc file with multiple embedded fonts, it patches all
of them and generates a new .ttc. Presumably the added symbols won't
look right in the non-Regular variants, but it's better than omitting
them.
This has not been tested on non-TTC fonts. I assume that they'll only
contain one font, which means they'll behave as expected.