Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server_name attribute to instances data source #73

Closed
wants to merge 3 commits into from

Conversation

ismirlia
Copy link
Collaborator

@ismirlia ismirlia commented Mar 5, 2024

Someone pointed out that the server_name was not listed as part of the instances data source. That seems like an oversight, and should make this data source easier to use.

This is what the data source output looks like now (this one element in the list):

...
{
      "health_status" = "OK"
      "license_repository_capacity" = 0
      "max_virtual_cores" = 8
      "maxmem" = 64
      "maxproc" = 8
      "memory" = 8
      "min_virtual_cores" = 1
      "minmem" = 2
      "minproc" = 1
      "networks" = tolist([
        {
          "external_ip" = ""
          "ip" = "196.168.2.48"
          "macaddress" = "fa:1f:37:65:21:21"
          "network_id" = ""
          "network_name" = "FLS Network (Do not use)"
          "type" = "fixed"
        },
        {
          "external_ip" = ""
          "ip" = "192.168.193.125"
          "macaddress" = "fa:1f:37:65:21:20"
          "network_id" = ""
          "network_name" = "FLSnetwork(Do not use)"
          "type" = "fixed"
        },
      ])
      "pin_policy" = "none"
      "placement_group_id" = "none"
      "processors" = 1
      "proctype" = "dedicated"
      "pvm_instance_id" = "dd8ea5b7-8650-4148-8736-6236601bf3af"
      "server_name" = "MattRPMBuildServer"
      "shared_processor_pool" = ""
      "shared_processor_pool_id" = ""
      "status" = "ACTIVE"
      "storage_pool" = "General-Flash-77"
      "storage_pool_affinity" = true
      "storage_type" = "tier3"
      "virtual_cores_assigned" = 1
    },
...

Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add it to ibm_pi_instance as well ?

@ismirlia ismirlia requested a review from michaelkad March 5, 2024 23:28
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ismirlia
Copy link
Collaborator Author

ismirlia commented Mar 7, 2024

Opened: IBM-Cloud#5184 closing this one

@ismirlia ismirlia closed this Mar 7, 2024
@michaelkad michaelkad deleted the instances-server-name branch September 6, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants