Fix overload management system deserialization issue #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-rte
force-pushed
the
fix_overload_management_system_deserialization_issue
branch
2 times, most recently
from
721c4c2 to
99528a0
Compare
3 tasks
|
#3174 added to highlight the behaviour before this PR. |
bc-rte
force-pushed
the
fix_overload_management_system_deserialization_issue
branch
from
99528a0 to
2eb2d16
Compare
|
…defer validation Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
…ents Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
bc-rte
force-pushed
the
fix_overload_management_system_deserialization_issue
branch
from
2eb2d16 to
951c253
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#3166
What kind of change does this PR introduce?
This PR refactors
OverloadManagementSystemSerDeto not defer creation of the element when deserializing a file.In order to maintain, only the validation of external network elements is now postponed.
What is the current behavior?
Currently, when reading a
Network,OverloadManagementSystems are created at the end, after attempting to deserialize extensions.What is the new behavior (if this is a feature change)?
OverloadManagementSystems are added to the network when read, allowing extensions to be deserialized properly.Does this PR introduce a breaking change or deprecate an API?
Other information:
No test was added to highlight the existing failing behaviour, because, in my understanding, testing it requires to create an extension.
An extension could be created in a separate PR to show the issue, but will require some additional functional validation to be mergeable.