Handle duplicate timeseries index #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throws exception in IrregularTimeSeriesIndex if the times array contains duplicate or is unordered Signed-off-by: lisrte <laurent.issertial@rte-france.com>
flo-dup
reviewed
Dec 4, 2024
time-series/time-series-api/src/main/java/com/powsybl/timeseries/TimeSeries.java
Show resolved
Hide resolved
time-series/time-series-api/src/test/java/com/powsybl/timeseries/TimeSeriesTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
flo-dup
approved these changes
Dec 6, 2024
|
5 tasks
olperr1
pushed a commit
that referenced
this pull request
Jan 22, 2025
* Skipped duplicate time index in CSV timeseries parser * Throws exception in IrregularTimeSeriesIndex if the times array contains duplicate or is unordered * Replace String join with text block in unit tests Signed-off-by: lisrte <laurent.issertial@rte-france.com> (cherry picked from commit be489a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
TimeSeriescan be created with duplicate time index value.What is the new behavior (if this is a feature change)?
Skipped row when duplicate time index is found during CSV
timeseriesparsingThrows exception in
IrregularTimeSeriesIndexif the times array contains duplicate or is unorderedDoes this PR introduce a breaking change or deprecate an API?
Other information:
Linked to a practical case in powsybl-dynawo PR 413