Add multi-substation layout feature #105
Conversation
tadam50
force-pushed
the
94-add-multi-substation-layout-feature
branch
from
f02c13c to
ff2c88d
Compare
So-Fras
force-pushed
the
94-add-multi-substation-layout-feature
branch
from
ff2c88d to
b77ac28
Compare
| SingleLineDiagram.drawMultiSubstations(network, ((Network) container).getSubstationStream().map(Identifiable::getId).toList(), | ||
| svgWriter, | ||
| metadataWriter, | ||
| sldParameters); |
There was a problem hiding this comment.
I think we shouldn't do that. Every time a network is loaded then clicking on the full network will launch this heavy process which cannot be interrupted, together with the same kind of heavy process on network area diagram. You're probably forced to kill the whole viewer each time you click on this with a big network.
Plus I noticed that when the viewer isn't used for a long time, the tree view forgets the selection for some reason and then the full network is selected by default. It's already taking off my laptop without this, so I can't imagine what would occur with this extra computation 🚀
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
So-Fras
force-pushed
the
94-add-multi-substation-layout-feature
branch
from
b77ac28 to
d69b126
Compare
There was a problem hiding this comment.
@YohannBachelierNH you committed with the wrong email: ybachelier@silicom.fr is not the email associated with your github profile. This leads to an unverified commit. Could you fix the commit by fixing your git config and then amending the commit with the correct email?
git config user.email "emaill@mail.example"
YohannBachelierNH
force-pushed
the
94-add-multi-substation-layout-feature
branch
from
322a5c0 to
bfdf390
Compare
Signed-off-by: Yohann Bachelier <ybachelier@neverhack.com>
YohannBachelierNH
force-pushed
the
94-add-multi-substation-layout-feature
branch
from
bfdf390 to
275ccd9
Compare
|
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
'Fixes #94'