Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bus connection status representation bug #521

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

So-Fras
Copy link
Member

@So-Fras So-Fras commented May 25, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
In bus breaker view, there is no difference on the diagram if a node is connected to a bus bar or not. The bus connection is represented as a full circle in both cases.

What is the new behavior?
If the node is not connected to the bus bar, the bus connection is represented as an empty circle.

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

@So-Fras So-Fras self-assigned this May 25, 2023
@So-Fras So-Fras requested a review from flo-dup May 25, 2023 19:40
@So-Fras So-Fras marked this pull request as ready for review May 30, 2023 19:58
@So-Fras So-Fras changed the title [WIP] Bus connection status representation bug Bus connection status representation bug May 30, 2023
@flo-dup flo-dup force-pushed the main branch 2 times, most recently from 1a28286 to 0248753 Compare June 7, 2023 15:43
So-Fras added 5 commits June 7, 2023 22:03
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@flo-dup flo-dup force-pushed the bug_bus_connection_status branch from d21396a to eae575a Compare June 7, 2023 20:04
So-Fras added 8 commits June 7, 2023 22:19
…w 2 3WT nodes to be connected to the same voltage level

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@flo-dup flo-dup force-pushed the bug_bus_connection_status branch from eae575a to abfb5d2 Compare June 7, 2023 20:21
So-Fras added 4 commits June 12, 2023 17:03
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
So-Fras added 2 commits June 13, 2023 10:29
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

90.2% 90.2% Coverage
0.0% 0.0% Duplication

@So-Fras So-Fras requested a review from geofjamg June 19, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change bug Something isn't working SLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant