Add parameters dedicated to Dynaflow (#118) #119
Conversation
dimbdr
requested review from
miovd,
gautierbureau,
PerninGuillaume and
flo-dup
flo-dup
requested review from
sylvlecl
and removed request for
miovd and
PerninGuillaume
There was a problem hiding this comment.
Thanks!
Implementation of loading from map still needs to be implemented :)
Note that we may implement at the same time that feature ? (but could be in another PR)
#104 (comment)
| @@ -120,11 +188,14 @@ public static DynaFlowParameters load(Map<String, String> properties) { | |||
| Optional.ofNullable(properties.get(SVC_REGULATION_ON)).ifPresent(prop -> parameters.setSvcRegulationOn(Boolean.parseBoolean(prop))); | |||
| Optional.ofNullable(properties.get(SHUNT_REGULATION_ON)).ifPresent(prop -> parameters.setShuntRegulationOn(Boolean.parseBoolean(prop))); | |||
| Optional.ofNullable(properties.get(AUTOMATIC_SLACK_BUS_ON)).ifPresent(prop -> parameters.setAutomaticSlackBusOn(Boolean.parseBoolean(prop))); | |||
| Optional.ofNullable(properties.get(DSO_VOLTAGE_LEVEL)).ifPresent(prop -> parameters.setDsoVoltageLevel(Double.parseDouble(prop))); | |||
There was a problem hiding this comment.
We need to implement the loading of new parameters here too.
Maybe code could be shared with loading from the module ?
There was a problem hiding this comment.
Note that we should also implement the method for update from a map, in DynaFlowProvider, not only the creation from a map.
There was a problem hiding this comment.
We need to implement the loading of new parameters here too.
Maybe code could be shared with loading from the module ?
I made a little change, by providing a new signature called loading.
The load method is not broken, and I can use the method loading with the new implemented method updateSpecificParameters in the DynaFlowProvider.
Though, I'm not quite sure about the way I implemented this updateSpecificParameters.
dynaflow/src/test/java/com/powsybl/dynaflow/DynaFlowParametersTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
… properties. Also, fix typo on lccAsLoads. Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
…p of properties Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
dynaflow/src/main/java/com/powsybl/dynaflow/DynaFlowParameters.java
Outdated
Show resolved
Hide resolved
dynaflow/src/main/java/com/powsybl/dynaflow/DynaFlowParameters.java
Outdated
Show resolved
Hide resolved
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restFixes #118
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Add new specific parameters to the Dynaflow API
What is the current behavior? (You can also link to an open issue here)
Currently, the Dynaflow API gives only 4 specific parameters.
What is the new behavior (if this is a feature change)?
Adding 4 more parameters to the Dynaflow API, for a total of 8 specific parameters.
Some were described in the PowSyBl documentation but were not available in the API. Documentation will be updated according to the current modifications.