Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor models #142

Merged
merged 14 commits into from
Dec 14, 2022
Merged

Refactor models #142

merged 14 commits into from
Dec 14, 2022

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Dec 12, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
Related to #113 and fixes #114

What kind of change does this PR introduce?
Refactor

What is the current behavior? (You can also link to an open issue here)

  • Each model corresponds to a BlackBoxModel
  • All models in same package
  • staticId, parameterSetId might be empty strings

What is the new behavior (if this is a feature change)?

  • A model corresponds to a BlackBoxModel only if it's modelled as such in dynawo, that is, only if it's written in the dyd file.
    Therefore the default network models do not implement the BlackBoxModel interface. A Model interface has been introduced above BlackBoxModel to model those default models.
  • Reorganize class architecture: each type of equipment has its own package. In each package there might be default network models together with BlackBoxModels.
  • Adding class VarMapping with parameters dynamicVariable and staticVariable instead of Pair<String, String>
  • Adding class VarConnection with parameters var1 and var2 instead of Pair<String, String>
  • Delete BlackBoxEventModel (duplicate of BlackBoxModel)
  • StaticId is optional

Does this PR introduce a breaking change or deprecate an API? yes

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

BAUDRIER Dimitri and others added 14 commits December 7, 2022 11:41
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>

Co-authored-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

89.4% 89.4% Coverage
2.7% 2.7% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing variable names in pairing lists
2 participants