Add hvdc and default shunt models #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DynaWaltzContext returns directly the dynamicModel linked to the static id or a default model/exception if not found depending on the method called Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Add side suffix value in CurrentLimitAutomaton name Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Handle MacroConnect index Remove connector commutativity and ConnectedModels Connect StandardBus only with DefaultModel Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Handle MacroConnect index Remove connector commutativity and ConnectedModels Connect StandardBus only with DefaultModel Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
…into refactor_macroconnect_creation # Conflicts: # dynawaltz/src/main/java/com/powsybl/dynawaltz/models/lines/StandardLine.java # dynawaltz/src/main/java/com/powsybl/dynawaltz/models/utils/BusUtils.java # dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/DynaWaltzTestUtil.java # dynawaltz/src/test/resources/dyd.xml
# Conflicts: # dynawaltz/src/main/java/com/powsybl/dynawaltz/DynaWaltzContext.java # dynawaltz/src/main/java/com/powsybl/dynawaltz/models/OmegaRef.java # dynawaltz/src/test/java/com/powsybl/dynawaltz/models/OmegaRefTest.java # dynawaltz/src/test/resources/dyd.xml
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
…dels # Conflicts: # dynawaltz/src/main/java/com/powsybl/dynawaltz/models/AbstractBlackBoxModel.java
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
flo-dup
requested changes
Mar 21, 2023
dynawaltz/src/main/java/com/powsybl/dynawaltz/models/AbstractBlackBoxModel.java
Outdated
Show resolved
Hide resolved
dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/AbstractDynamicModelXmlTest.java
Outdated
Show resolved
Hide resolved
dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/AbstractDynamicModelXmlTest.java
Outdated
Show resolved
Hide resolved
dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/AbstractDynamicModelXmlTest.java
Outdated
Show resolved
Hide resolved
flo-dup
reviewed
Mar 21, 2023
dynawaltz/src/main/java/com/powsybl/dynawaltz/models/buses/StandardBus.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
approved these changes
Mar 22, 2023
dynawaltz/src/main/java/com/powsybl/dynawaltz/models/generators/AbstractGeneratorModel.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
flo-dup
reviewed
Mar 22, 2023
There was a problem hiding this comment.
Now that the DefaultShuntModel has been added, I just realize, shouldn't we protect the StandardBus from being connected to any default model?
We should add checkLinkedDynamicModels(bus.getShuntCompensatorStream(), "shunt", context); to the checks, or do it on all type of connectables with something like bus.getConnectedTerminalStream().map(Terminal::getConnectable).forEach(c -> checkLinkedDynamicModels(c, context));
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
|
SonarCloud Quality Gate failed. |
flo-dup
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)