Add static var compensator #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lisrte
force-pushed
the
check_static_models
branch
2 times, most recently
from
c6949e6 to
70213c4
Compare
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
flo-dup
force-pushed
the
add_static_var_compensator
branch
from
eda7369 to
178a32a
Compare
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
approved these changes
Apr 19, 2023
| @@ -91,7 +93,8 @@ private static Stream<Arguments> provideEquipmentModelData() { | |||
| Arguments.of("genFictitious", GeneratorFictitious.class, EurostagTutorialExample1Factory.create(), "GEN", "BBM_GEN", "GF", "GeneratorFictitious"), | |||
| Arguments.of("gen", GeneratorSynchronous.class, EurostagTutorialExample1Factory.create(), "GEN", "BBM_GEN", "GSFWPR", "GeneratorSynchronousFourWindingsProportionalRegulations"), | |||
| Arguments.of("omegaGen", OmegaRefGenerator.class, EurostagTutorialExample1Factory.create(), "GEN", "BBM_GEN", "GPQ", "GeneratorPQ"), | |||
| Arguments.of("transformer", TransformerFixedRatio.class, EurostagTutorialExample1Factory.create(), "NGEN_NHV1", "BBM_NGEN_NHV1", "TFR", "TransformerFixedRatio") | |||
| Arguments.of("transformer", TransformerFixedRatio.class, EurostagTutorialExample1Factory.create(), "NGEN_NHV1", "BBM_NGEN_NHV1", "TFR", "TransformerFixedRatio"), | |||
| Arguments.of("svc", StaticVarCompensatorModel.class, SvcTestCaseFactory.create(), "SVC2", "BBM_SVC", "svc", "StaticVarCompensatorPV") | |||
There was a problem hiding this comment.
Just a comment, which is not related to current PR, thus this should not be addressed here. As the name of the file is deduced in AbstractModelSupplierTest::getResourceAsStream the ctrl+click is not working in the IDE to navigate to the groovy file. Having "/dynamicModel/svc.groovy" instead of "svc" would be more convenient.
| @@ -48,7 +50,7 @@ class DynamicModelsSupplierTest extends AbstractModelSupplierTest { | |||
|
|
|||
| @Test | |||
| void testGroovyExtensionCount() { | |||
| assertEquals(10, EXTENSIONS.size()); | |||
There was a problem hiding this comment.
Why did we keep that unit test?
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements