Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeneratorSynchronous renamed to SynchronousGenerator #225

Merged
merged 6 commits into from
Jun 9, 2023

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented May 19, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Yes, fixes #178

@flo-dup flo-dup force-pushed the synchronous_rename branch from 5f5adfc to 103e276 Compare May 19, 2023 15:36
@flo-dup flo-dup added the Breaking Change API is broken label May 19, 2023
flo-dup and others added 2 commits June 8, 2023 13:58
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte force-pushed the synchronized_synchronous branch from 9ce5d98 to fdda809 Compare June 8, 2023 12:02
flo-dup and others added 3 commits June 8, 2023 14:07
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte force-pushed the synchronous_rename branch from 103e276 to f29a0d1 Compare June 8, 2023 12:31
Base automatically changed from synchronized_synchronous to main June 9, 2023 08:19
# Conflicts:
#	dynawaltz-dsl/src/test/java/com/powsybl/dynawaltz/dsl/DynamicModelsSupplierTest.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/frequencysynchronizers/OmegaRef.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/generators/SynchronousGenerator.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/generators/SynchronousGeneratorModel.java
#	dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/ActivePowerVariationEventXmlTest.java
#	dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/DynaWaltzTestUtil.java
#	dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/OmegaRefModelXmlTest.java
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit c439ba3 into main Jun 9, 2023
@flo-dup flo-dup deleted the synchronous_rename branch June 9, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change API is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeneratorSynchronous to SynchronousGenerator
2 participants