Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename EquipmentBlackBoxModelModel to EquipmentBlackBoxModel #254

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Jun 15, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #244

@Lisrte Lisrte self-assigned this Jun 15, 2023
@Lisrte Lisrte requested a review from gautierbureau June 20, 2023 14:00
@Lisrte Lisrte force-pushed the rename_network_to_default branch 2 times, most recently from 3aeda8d to 638c6a8 Compare June 21, 2023 14:10
Base automatically changed from rename_network_to_default to main June 21, 2023 18:21
@Lisrte Lisrte force-pushed the rename_model_model branch from 6aacdf1 to 683f9f8 Compare June 22, 2023 07:59
Lisrte added 3 commits June 22, 2023 10:00
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
#	dynawaltz-dsl/src/main/groovy/com/powsybl/dynawaltz/dsl/AbstractEquipmentGroovyExtension.groovy
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/hvdc/DefaultHvdcModel.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/hvdc/HvdcPvDangling.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/hvdc/HvdcVscDangling.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/lines/DefaultLineModel.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/transformers/DefaultTransformerModel.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/utils/SideConverter.java
#	dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/DisconnectHvdcEventXmlTest.java
#	dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/HvdcXmlTest.java
#	dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/WeccGenXmlTest.java

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte force-pushed the rename_model_model branch from 683f9f8 to 5a7e260 Compare June 22, 2023 08:00
Signed-off-by: Lisrte <laurent.issertial@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@geofjamg geofjamg merged commit a6c7c7c into main Jun 23, 2023
@geofjamg geofjamg deleted the rename_model_model branch June 23, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelModel suffix should be simplfied
4 participants