Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip empty automatons #265

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Skip empty automatons #265

merged 3 commits into from
Sep 26, 2023

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Jul 7, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature

What is the new behavior (if this is a feature change)?
For TapChanger and TapChangerBlocking automatons : skip the automaton if none of equipments linked to it have the expected properties

@Lisrte Lisrte requested a review from gautierbureau July 7, 2023 12:23
@Lisrte Lisrte self-assigned this Jul 7, 2023
@flo-dup flo-dup force-pushed the skip_empty_automaton branch from b2affc7 to d728aa1 Compare September 25, 2023 16:18
Base automatically changed from dsl_logger to main September 26, 2023 12:47
… if none of equipments linked to it have the expected properties

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@flo-dup flo-dup force-pushed the skip_empty_automaton branch from d728aa1 to bf6f216 Compare September 26, 2023 13:05
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.2% 83.2% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 99b3acc into main Sep 26, 2023
@flo-dup flo-dup deleted the skip_empty_automaton branch September 26, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants