Add an implementation of GlskProvider that uses GlskDocument as data source #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source to load GLSKs for all countries. Unavailable GLSKs will be replaced by default proportional country GLSK. Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
OpenSuze
reviewed
Sep 11, 2023
...rc/main/java/com/powsybl/flow_decomposition/glsk_provider/GlskDocumentBasedGlskProvider.java
Show resolved
Hide resolved
...est/java/com/powsybl/flow_decomposition/glsk_provider/GlskDocumentBasedGlskProviderTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
annetill
approved these changes
Sep 13, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the new behavior (if this is a feature change)?
Add an implementation of GlskProvider that uses GlskDocument as data source to load GLSKs for all countries. Unavailable GLSKs will be replaced by default proportional country GLSK.
The new implementation also allows to choose the GLSK serie in the document based on :