Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a check to avoid a nan when calculating the leaving flow from danglingline #120

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

kahyami
Copy link
Contributor

@kahyami kahyami commented Oct 17, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@kahyami kahyami changed the title add a check to avoid a nan when we calculating the leaving flow from danglingline add a check to avoid a nan when calculating the leaving flow from danglingline Oct 17, 2023
kahyami and others added 2 commits October 17, 2023 13:47
…danglingline

Signed-off-by: KAHYA Amira <amira.kahya@rte-france.com>
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
@murgeyseb murgeyseb force-pushed the fix_leaving_flow_from_danglingline branch from b75ca43 to 7a9a387 Compare October 17, 2023 11:48
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@phiedw phiedw merged commit 20289ea into main Oct 18, 2023
7 checks passed
@phiedw phiedw deleted the fix_leaving_flow_from_danglingline branch October 18, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants