AutoGlskProvider uses connected generators, and don't crash when the sum of target Ps is zero #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take only connected generators into account for the AutoGlskProvider. If the sum of targetPs of a country equals 0.0, all generators take an equal part into the total value. This prevents dividing by 0. Signed-off-by: Guillaume Verger <guillaume.verger@artelys.com>
OpenSuze
reviewed
Jan 19, 2024
...composition/src/main/java/com/powsybl/flow_decomposition/glsk_provider/AutoGlskProvider.java
Show resolved
Hide resolved
Signed-off-by: Guillaume Verger <guillaume.verger@artelys.com>
|
OpenSuze
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take only connected generators into account for the AutoGlskProvider.
If the sum of targetPs of a country equals 0.0, all generators take an equal part into the total value. This prevents dividing by 0.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
The AutoGlskProvider takes into consideration connected generators only.
It also fixes a bug (dividing by 0) when the generators have a target P equal to 0.