Fix flow decomposition loss compensation when dangling lines have shunt susceptance #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caio Luke <caioluke97@gmail.com>
OpenSuze
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Thank you for this PR !
It's well spotted, we might have been too restrictive with only resistance and not impedance.
Could you fix this in the documentation please ?
A special treatment is done on tie lines, where instead of compensating the losses on the sending terminal, losses are compensated at both sides proportionally to the impedance of each half line.
Signed-off-by: Caio Luke <caioluke97@gmail.com>
|
|
@OpenSuze done! |
OpenSuze
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Current loss compensation for TieLines only work if the corresponding DanglingLines don't have a shunt susceptance.
What is the new behavior (if this is a feature change)?
Instead of calculating the loss for each DanglingLine proportionally to the resistance, use dangling line's boundary P to calculate it.
Does this PR introduce a breaking change or deprecate an API?