Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IIDM 1.2] Identifiable.name is optional + introduce getOptionalName(), getNameOrId() + deprecate getName() #135

Closed
miovd opened this issue Jun 23, 2020 · 1 comment · Fixed by #142

Comments

@miovd
Copy link

miovd commented Jun 23, 2020

  • Do you want to request a feature or report a bug?
    Feature

  • What is the current behavior?
    Identifiable.getName() never returns null: either it returned the defined name or the id.

  • What is the expected behavior?
    name attribute should not be systematic: the API should be clearer about returning the real name or the id. New methods getOptionalName() and getNameOrId() are hence introduced.

  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, spectrum, etc)

cf. powsybl/powsybl-core#1243

@sebalaig
Copy link
Contributor

Duplication of issue #124, fixed by PR #142. => closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants