Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IIDM V1.2] Add getNameOrId() and getOptionalName() into Identifiable (#124) #142

Merged
merged 4 commits into from
Jul 21, 2020
Merged

[IIDM V1.2] Add getNameOrId() and getOptionalName() into Identifiable (#124) #142

merged 4 commits into from
Jul 21, 2020

Conversation

sebalaig
Copy link
Contributor

@sebalaig sebalaig commented Jul 10, 2020 •
edited
Loading

Identifiable::getName() has been removed, user has to call getNameOrId() if needed or getOptionalName().

Signed-off-by: Sébastien LAIGRE slaigre@silicom.fr

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
#124

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@sebalaig
Add getNameOrId() and getOptionalName() and remove deprecated getName…
d9482dd 
…() methods from identifiable

Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
@sebalaig sebalaig self-assigned this Jul 10, 2020
@sebalaig sebalaig linked an issue Jul 10, 2020 that may be closed by this pull request
[IIDM v1.2] Add methods to Identifiable to get its ID or its name #124
Closed
@sebalaig sebalaig requested a review from mathbagu July 10, 2020 16:50
@sebalaig sebalaig changed the title Add getNameOrId() and getOptionalName() into Identifiable [IIDM V1.2] Add getNameOrId() and getOptionalName() into Identifiable Jul 10, 2020
mathbagu
mathbagu requested changes Jul 15, 2020
View reviewed changes
Copy link

@mathbagu mathbagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should return an empty string when the name is absent. I think it could be ok regarding to the Java API

sebalaig and others added 2 commits July 15, 2020 18:30
@sebalaig
Make getOptionalName return an empty string if the Identifiable has n…
1ec4014 
…o name

Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Fix implementation and add more tests
edfcb69 
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
@sebalaig sebalaig changed the title [IIDM V1.2] Add getNameOrId() and getOptionalName() into Identifiable [IIDM V1.2] Add getNameOrId() and getOptionalName() into Identifiable (#124) Jul 21, 2020
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

48.7% 48.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@mathbagu mathbagu merged commit 92fdb79 into integration/v1.2.0 Jul 21, 2020
@mathbagu mathbagu deleted the issue124-add-getNameOrId branch July 21, 2020 16:30
mathbagu pushed a commit that referenced this pull request Jul 22, 2020
@sebalaig
[IIDM V1.2] Add getNameOrId() and getOptionalName() into Identifiable (…
276df64 
…#124) (#142)

Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
@sebalaig sebalaig linked an issue Jul 24, 2020 that may be closed by this pull request
[IIDM 1.2] Identifiable.name is optional + introduce getOptionalName(), getNameOrId() + deprecate getName() #135
Closed
@sebalaig sebalaig mentioned this pull request Jul 24, 2020
Closed
@sebalaig sebalaig mentioned this pull request Aug 7, 2020
Closed
mathbagu pushed a commit that referenced this pull request Sep 9, 2020
@sebalaig @mathbagu
[IIDM V1.2] Add getNameOrId() and getOptionalName() into Identifiable (…
ae0f587 
…#124) (#142)

Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathbagu mathbagu mathbagu requested changes

Assignees

@sebalaig sebalaig

Labels
PR: ready-to-be-merged
Projects
None yet
Milestone
No milestone
2 participants
@sebalaig @mathbagu