[IIDM V1.2] Removed duplicates in VoltageLevel::getConnectables (#46) #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbagu
reviewed
Jul 15, 2020
| BOOST_AUTO_TEST_CASE(getConnectablesCheckUnique) { | ||
| const Network network = createLineTestNetwork2(); | ||
| const VoltageLevel& vl = network.getVoltageLevel("VL1"); | ||
| BOOST_CHECK_EQUAL(1UL, boost::size(vl.getConnectables<Line>())); |
There was a problem hiding this comment.
Could you check that vl.getConnectableCount() also return 1?
There was a problem hiding this comment.
You're right, it fails... I have to patch getConnectableCount() also
mathbagu
force-pushed
the
integration/v1.2.0
branch
from
92fdb79 to
276df64
Compare
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
…om a VL/substation Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
sebalaig
force-pushed
the
issue46-fix-duplicates-getConnectables
branch
from
ab14754 to
9d05f88
Compare
… add tests Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
mathbagu
approved these changes
Aug 10, 2020
mathbagu
added
PR: ready-to-be-merged
and removed
PR: waiting-for-info-reviewer
PR: waiting-for-review
labels
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sébastien LAIGRE slaigre@silicom.fr
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#46
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)