Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XML unparsing under windows #446

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Conversation

sebalaig
Copy link
Contributor

@sebalaig sebalaig commented Nov 28, 2022

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
XML unparsing in a file duplicates the network under Windows. It's ok under linux.

What is the new behavior (if this is a feature change)?
XML unparsing is ok on Windows (and linux also)

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)
    No

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
@sebalaig sebalaig force-pushed the fix-unparsing-windows branch from d95757f to 698173d Compare November 28, 2022 12:46
@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@gautierbureau gautierbureau merged commit 8a1fec9 into main Nov 29, 2022
@gautierbureau gautierbureau deleted the fix-unparsing-windows branch November 29, 2022 08:00
@valleefred valleefred mentioned this pull request Jun 7, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants