Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pb in tck terminal finder tests #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FranckLecuyer
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

Test method testLineTerminal1 and testLineTerminal2 fail in TerminalFinderIT class with network-store implementation.
see PR in network-store-client : powsybl/powsybl-network-store#428

What is the new behavior (if this is a feature change)?
Test methods now succeeds

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Copy link
Contributor Author

FranckLecuyer commented Aug 13, 2024

Waiting for PR powsybl/powsybl-network-store#428 to be merged ...

Copy link

sonarcloud bot commented Aug 13, 2024

@ayolab ayolab self-requested a review August 19, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants