Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move regulating from regulating equipment to regulatingPoint #85

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

EtienneLt
Copy link
Contributor

@EtienneLt EtienneLt commented Dec 4, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:
linked with powsybl/powsybl-network-store#483

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I import a network, I have this error:
grid-network-store-server-1 | org.postgresql.util.PSQLException: ERROR: column "regulating" is of type boolean but expression is of type character varying

@EtienneLt
Copy link
Contributor Author

When I import a network, I have this error: grid-network-store-server-1 | org.postgresql.util.PSQLException: ERROR: column "regulating" is of type boolean but expression is of type character varying

Yes I found the mistake

EtienneLt and others added 5 commits December 9, 2024 15:26
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK
Test OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants