Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle toggle popover when mouseover equipment #100

Merged
merged 15 commits into from
Oct 31, 2024
Merged

handle toggle popover when mouseover equipment #100

merged 15 commits into from
Oct 31, 2024

Conversation

souissimai
Copy link
Contributor

@souissimai souissimai commented Sep 24, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?
handle popover when onhovering equipment

What is the current behavior?

Nothing happen when onhovering equipment from NAD

What is the new behavior (if this is a feature change)?
Show popover when onhovering equipment ( line or twt ) from NAD

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@souissimai
handle toggle popover when mouseover equipment
c46b262 
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
@jamal-khey jamal-khey self-requested a review September 25, 2024 15:15
jamal-khey
jamal-khey reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@jamal-khey jamal-khey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Ok

src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts Outdated Show resolved Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts Outdated Show resolved Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts Outdated Show resolved Hide resolved
@YenguiSeddik YenguiSeddik self-requested a review September 30, 2024 09:07
@souissimai
Merge branch 'main' into display_tooltip_for_nad
406e90a
@souissimai
requested changes
bc33e9d 
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
display tootltip only for line an 2twt equipments
ff4811a 
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
jamal-khey
jamal-khey previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@jamal-khey jamal-khey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test and code Ok

YenguiSeddik
YenguiSeddik previously approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@YenguiSeddik YenguiSeddik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test & code : ok

@SlimaneAmar SlimaneAmar requested a review from flo-dup October 8, 2024 09:05
flo-dup
flo-dup requested changes Oct 8, 2024
View reviewed changes
src/components/network-area-diagram-viewer/diagram-utils.ts Show resolved Hide resolved
src/components/network-area-diagram-viewer/diagram-utils.ts Outdated Show resolved Hide resolved
src/components/network-area-diagram-viewer/diagram-utils.ts Outdated Show resolved Hide resolved
src/components/network-area-diagram-viewer/diagram-utils.ts Outdated Show resolved Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts Outdated Show resolved Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts Outdated Show resolved Hide resolved
src/components/network-area-diagram-viewer/diagram-utils.ts Outdated Show resolved Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts Outdated Show resolved Hide resolved
demo/src/diagram-viewers/add-diagrams.ts Outdated Show resolved Hide resolved
@souissimai
renaming ..
5861215 
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai souissimai dismissed stale reviews from YenguiSeddik and jamal-khey via 5861215 October 9, 2024 11:15
@souissimai
requested changes
051a7da 
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
requested changes
8245ea7 
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
requested changes
529d441 
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
renaming
7b654fd 
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
requested changes
bd1540b 
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
fix
1f3c190 
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
renaming ..
14ffeb1 
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
requested changes
31b18f9 
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai souissimai requested a review from flo-dup October 30, 2024 14:52
flo-dup
flo-dup requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@flo-dup flo-dup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor comments left!

src/components/single-line-diagram-viewer/single-line-diagram-viewer.ts Outdated
@@ -120,7 +120,7 @@ export class SingleLineDiagramViewer {
arrowSvg: string;
arrowHoverSvg: string;
svgDraw: Svg | undefined;
handleTogglePopover: HandleTogglePopoverType | null;
handleTogglePopover: OnToggleSLDHoverCallbackType | null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'd better change the variable name also. And acronym should not have full upper case in variable/class names

Suggested change
handleTogglePopover: OnToggleSLDHoverCallbackType | null;
onToggleHoverCallback: OnToggleSldHoverCallbackType | null;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to change the variable name, I'll take care of it.

src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts Outdated Show resolved Hide resolved
souissimai and others added 2 commits October 31, 2024 11:23
@souissimai
renaming..
22cc043 
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
@flo-dup
Minor fixes
1ba9b8c 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@flo-dup flo-dup merged commit 1164471 into main Oct 31, 2024
4 of 5 checks passed
@flo-dup flo-dup deleted the display_tooltip_for_nad branch October 31, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo-dup flo-dup flo-dup approved these changes

@jamal-khey jamal-khey Awaiting requested review from jamal-khey

@YenguiSeddik YenguiSeddik Awaiting requested review from YenguiSeddik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@souissimai @jamal-khey @flo-dup @YenguiSeddik