[Typescript] Fix OnBreakerCallbackType type #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamal-khey <myjamal89@gmail.com>
jamal-khey
force-pushed
the
jamal-khey/ts-migration-components-diagrams
branch
from
26ae29d to
282f5d0
Compare
|
flo-dup
requested changes
Oct 25, 2024
…ngleLineDiagramViewer component Signed-off-by: jamal-khey <myjamal89@gmail.com>
jamal-khey
force-pushed
the
jamal-khey/ts-migration-components-diagrams
branch
from
61ea9fb to
96c180a
Compare
|
flo-dup
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
FIX typescript type
What is the current behavior?
No Behavior change
What is the new behavior (if this is a feature change)?
No Behavior change
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
When instantiating the
SingleLineDiagramViewerclass, you need to update the parameter type of theonBreakerCallback. The type of the switch element parameter is nowswitchElementinstead of the previous type.Other information: