Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nad-viewer following powsybl-diagram v4.6.0 release #110

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Oct 31, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Update powsybl-diagram to v4.6.0 (metadata changes)

What is the current behavior?
moving nodes in nad-viewer works only with svgs from powsybl-diagram <v4.6.0

What is the new behavior (if this is a feature change)?
moving nodes in nad-viewer works onlywith svgs from powsybl-diagram >=v4.6.0

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

…gram (#92)

Signed-off-by: Massimo Ferraro <massimo.ferraro@soft.it>
)

Signed-off-by: Massimo Ferraro <massimo.ferraro@soft.it>
Signed-off-by: Massimo Ferraro <massimo.ferraro@soft.it>
@flo-dup flo-dup force-pushed the integration/nad_4.6.0 branch from efd3feb to a54ec44 Compare October 31, 2024 15:25
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@flo-dup flo-dup merged commit 0a3c2a9 into main Nov 4, 2024
4 of 5 checks passed
@flo-dup flo-dup deleted the integration/nad_4.6.0 branch November 4, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants