Replace release workflow and add node token as input #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinebhs
force-pushed
the
replace-release-workflow
branch
from
b2c728c to
48a6cbb
Compare
Signed-off-by: BOUHOURS Antoine <antoine.bouhours@rte-france.com>
antoinebhs
force-pushed
the
replace-release-workflow
branch
from
48a6cbb to
8ef7ee6
Compare
|
It it works, we can probably also share the workflows of commons-ui and this repo in https://github.com/powsybl/github-ci/tree/main/.github/workflows |
Signed-off-by: BOUHOURS Antoine <antoine.bouhours@rte-france.com>
Signed-off-by: BOUHOURS Antoine <antoine.bouhours@rte-france.com>
antoinebhs
force-pushed
the
replace-release-workflow
branch
from
94e5880 to
e3cbf7f
Compare
flo-dup
reviewed
Nov 5, 2024
Signed-off-by: Florian Dupuy <66690739+flo-dup@users.noreply.github.com>
Co-authored-by: Florian Dupuy <66690739+flo-dup@users.noreply.github.com> Signed-off-by: Antoine Bouhours <antoine.bouhours@rte-france.com>
|
flo-dup
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
In the publish workflow, it was necessary to generate a release notes to publish on npmjs, now running the action generate the release note and publish on npmjs. See README for details.
It also avoid using credentials of one person and node auth token is added as input (and masked for the rest of the action as per https://dev.to/leading-edje/masking-input-parameters-in-github-actions-1ci) waiting for a native implementation of this in github actions (https://github.com/orgs/community/discussions/12764)
This is based on the work of @TheMaskedTurtle in commons-ui (https://github.com/gridsuite/commons-ui/blob/main/.github/workflows/release.yml)