Disable node interaction when no metadata is available in network area diagram viewer #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a diagram viewer Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
flo-dup
reviewed
Nov 5, 2024
| @@ -97,6 +97,8 @@ export class NetworkAreaDiagramViewer { | |||
| this.originalWidth = 0; | |||
| this.originalHeight = 0; | |||
| this.dynamicCssRules = customDynamicCssRules ?? DEFAULT_DYNAMIC_CSS_RULES; | |||
| // if no metadata is available disable node interaction | |||
| enableNodeInteraction = diagramMetadata == null ? false : enableNodeInteraction; | |||
There was a problem hiding this comment.
We should also disable the svgDraw.on('mouseover', ...). For that, shouldn't we rather give a hasMetadata boolean to init method?
There was a problem hiding this comment.
Hover callback disabled if there is no metadata
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
flo-dup
approved these changes
Nov 5, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
In network area diagram viewer, the node interaction can be enabled even if there is no metadata available
What is the new behavior (if this is a feature change)?
In network area diagram viewer, when there is no metadata available the node interaction is disabled
Does this PR introduce a breaking change or deprecate an API?