Adds CSS rules on SVG to help performances. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before loading, rules to hide (cull) are added, then, after a zoom threshold is passed, the elements are shown. Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
EstherDarkish
changed the title
added 7 commits
June 11, 2024 10:14
Better CSS selectors for voltage levels. Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
…y style, not only the display value. Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
EstherDarkish
changed the title
added 6 commits
August 22, 2024 14:37
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com> # Conflicts: # src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
added 4 commits
September 6, 2024 14:44
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
klesaulnier
previously approved these changes
Sep 9, 2024
src/components/network-area-diagram-viewer/dynamic-css-utils.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: klesaulnier <42617371+klesaulnier@users.noreply.github.com> Signed-off-by: Charly B <47325354+EstherDarkish@users.noreply.github.com>
klesaulnier
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before loading, rules to hide (cull) are added, then, after a zoom threshold is passed, the elements are shown.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
feature
What is the current behavior?
In the network diagram viewer, all the information is always visible, even if it is too small to be readable or relevant.
What is the new behavior (if this is a feature change)?
When enabled, the level of detail of the network diagram changes depending on the zoom level. When zooming in, more data is displayed. When zooming out, less data is displayed.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
The constructor of the NetworkAreaDiagramViewer has two new additional parameters: the boolean enabling or not the level of detail filtering, and the CSS threshold rules used for the level of detail.
An example of level of detail application is provided in the demo/src/diagram-viewers/add-diagrams.js file
Other information: