Make voltage level nodes movable in network area diagram viewer #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Make basic voltage level nodes (one bus) movable in network area diagram * Enable mouse changing on panning * Fix conflict between moving nodes and panning diagram * Move correctly phase shifting transformers and HVDC lines edges * Handle desc in edges Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
…65) Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
… diagram (#71) Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
… viewer (#66) * Move three windings transformers in network area diagram * Move dangling lines and voltage levels with unknown buses in network area diagram Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
…ram (#73) Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
…rs in network area diagram (#81) Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #41 and fixes #72
Please refer to the PRs listed below
What kind of change does this PR introduce?
feature
What is the current behavior?
The typescript network-area diagram viewer is static, you can only zoom and move the whole SVG
What is the new behavior (if this is a feature change)?
The typescript network-area diagram viewer allows to move voltage level nodes
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
the constructor of the NetworkAreaDiagramViewer has new additional parameters: the callback and a boolean flag parameter.
Examples are provided in the demo/src/diagram-viewers/add-diagrams.js file
Other information:
this PR includes changes from the following PRs: