-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of PhaseTapChangerTapPositionAction for 3wt #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
# Conflicts: # src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisWithActionsTest.java
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Hadrien-Godard
approved these changes
Sep 20, 2023
annetill
requested changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small clean needed, but functionally right.
src/main/java/com/powsybl/openloadflow/sa/AbstractSecurityAnalysis.java
Outdated
Show resolved
Hide resolved
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
# Conflicts: # src/main/java/com/powsybl/openloadflow/sa/AbstractSecurityAnalysis.java
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
…powsybl-open-loadflow into support_t3wt_pst_action
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
…powsybl-open-loadflow into support_t3wt_pst_action
annetill
changed the title
Support t3wt pst action
Support of PhaseTapChangerTapPositionAction for 3wt
Sep 27, 2023
annetill
reviewed
Sep 27, 2023
src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java
Show resolved
Hide resolved
annetill
approved these changes
Sep 28, 2023
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
This PR enables to apply a pst action on a Three Windings Transformer
What is the current behavior?
Three Windings Transformers are not supported by pst actions
What is the new behavior (if this is a feature change)?
Three Windings Transformers are supported by pst actions
Does this PR introduce a breaking change or deprecate an API?
Other information: