Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of PhaseTapChangerTapPositionAction for 3wt #849

Merged
merged 20 commits into from
Sep 28, 2023

Conversation

vmouradian
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?
This PR enables to apply a pst action on a Three Windings Transformer

What is the current behavior?
Three Windings Transformers are not supported by pst actions

What is the new behavior (if this is a feature change)?
Three Windings Transformers are supported by pst actions

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
# Conflicts:
#	src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisWithActionsTest.java
@vmouradian vmouradian self-assigned this Sep 20, 2023
vmouradian and others added 3 commits September 20, 2023 14:45
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
Copy link
Member

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small clean needed, but functionally right.

vmouradian and others added 11 commits September 22, 2023 17:07
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/sa/AbstractSecurityAnalysis.java
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill requested a review from geofjamg September 27, 2023 18:29
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill changed the title Support t3wt pst action Support of PhaseTapChangerTapPositionAction for 3wt Sep 27, 2023
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

97.1% 97.1% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit 3445359 into main Sep 28, 2023
6 checks passed
@annetill annetill deleted the support_t3wt_pst_action branch September 28, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants