Fix hvdc ra inverted #1036
Merged
Fix hvdc ra inverted #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thiriondan <daniel.thirion@rte-france.com>
Signed-off-by: thiriondan <daniel.thirion@rte-france.com>
danielthirion
force-pushed
the
fix_hvdc_ra_inverted
branch
from
744fc98 to
2157331
Compare
phiedw
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Bug fix : the convention on which to invert direction of HVDC RA in the Crac Creator was wrong. As explained in the ENTSOE documentation (https://eepublicdownloads.entsoe.eu/clean-documents/EDI/Library/crac/CRAC_implementation_guide_v2r3.pdf L332-333)
In_Domain.mRID: the area of the related oriented border study where the energy flows into.
Out_Domain.mRID: the area of the related oriented border study where the energy comes from.
What is the current behavior?
Direction of HVDC is inverted when compared to CVG results. CORESO raised the issue in a ticket.
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: