Fix zero flows in result due to instant handling in SystematicSensitivityResult #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…computations Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
phiedw
changed the title
phiedw
added
bug
pet-mit
approved these changes
Nov 5, 2024
phiedw
added a commit
that referenced
this pull request
Nov 5, 2024
…computations (#1189) Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
bqth29
pushed a commit
that referenced
this pull request
Nov 26, 2024
…computations (#1189) Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com> Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The SystematicSensitivityResult will return 0 if you ask it for the flow on a line at the curative instant if the computation was only done for the outage instant or auto instant. However, this is the nominal case for curative cnecs after a second preventive, since to avoid duplicating the sensitivity computations, we only run them at the outage instant for contingencies where no auto/curative actions were applied.
This resulted in flows equal to 0 in the RaoResult and exported in the json.
What is the new behavior (if this is a feature change)?
Now checks all instant prior to find the latest result available.
Does this PR introduce a breaking change or deprecate an API?
Other information:
Issue detected during SWE capacity calculation.