Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rao parameters separate unit from objective function type #1197

Open
wants to merge 1 commit into
base: rao_parameters_remove_curative_stop_criterion
Choose a base branch
from

Conversation

pjeanmarie
Copy link
Member

@pjeanmarie pjeanmarie commented Nov 19, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

#1084

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

    if "type" in obj_fun:
        if "MAX_MIN_MARGIN" in obj_fun["type"]:
            new_obj_fun["type"] = "MAX_MIN_MARGIN"
        elif "MAX_MIN_RELATIVE_MARGIN" in obj_fun["type"]:
            new_obj_fun["type"] = "MAX_MIN_RELATIVE_MARGIN"
        if "MEGAWATT" in obj_fun["type"]:
            new_obj_fun["unit"] = "MW"
        elif "AMPERE" in obj_fun["type"]:
            new_obj_fun["unit"] = "A"

Other information:

@pjeanmarie pjeanmarie changed the base branch from main to rao_parameters_remove_curative_stop_criterion November 19, 2024 10:26
@pjeanmarie pjeanmarie added breaking-change Changes could break users' code PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) labels Nov 19, 2024
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_unit_from_objective_function_type branch from e1e221d to 8cadd8c Compare November 19, 2024 10:36
@pjeanmarie pjeanmarie added the PR: waiting-for-review This PR is waiting to be reviewed label Nov 19, 2024
@pjeanmarie pjeanmarie requested a review from obrix November 19, 2024 11:06
@pjeanmarie pjeanmarie linked an issue Nov 25, 2024 that may be closed by this pull request
Copy link
Member

@obrix obrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment on deserialization of unit, it may be simplified.

@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_unit_from_objective_function_type branch from 8cadd8c to 02f55a5 Compare November 29, 2024 09:09
@pjeanmarie pjeanmarie force-pushed the rao_parameters_remove_curative_stop_criterion branch from 78c32dc to 4371fee Compare November 29, 2024 10:17
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_unit_from_objective_function_type branch from 02f55a5 to c85394f Compare November 29, 2024 10:18
@Godelaine Godelaine requested a review from phiedw November 29, 2024 13:21
@pjeanmarie pjeanmarie force-pushed the rao_parameters_remove_curative_stop_criterion branch from 4371fee to d726fbb Compare December 9, 2024 10:13
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
@pjeanmarie pjeanmarie force-pushed the rao_parameters_separate_unit_from_objective_function_type branch from c85394f to d588d48 Compare December 9, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes could break users' code PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make RaoParameters generic
2 participants