Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power Gradient Constraint #1229

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

bqth29
Copy link
Collaborator

@bqth29 bqth29 commented Dec 9, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
Fixes #1218

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29 bqth29 added feature New feature or request intertemporality Encompasses the use of multi-time-steps optimization and intertemporal constraints labels Dec 9, 2024
@bqth29 bqth29 requested a review from Godelaine December 9, 2024 16:03
@bqth29
Copy link
Collaborator Author

bqth29 commented Dec 9, 2024

@Godelaine what do you think about adding a serializer and a deserializer for this?

I do not think it is necessary for now but there may be a need at some point.

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Copy link
Collaborator Author

bqth29 commented Dec 10, 2024

Regarding upward/downward variants, I see 2 possible implementations:

  1. the gradient is always positive and the direction comes from the variationDirection attribute
  2. the direction is given by the sign of the gradient, no variationDirection needed

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29 bqth29 added the PR: waiting-for-review This PR is waiting to be reviewed label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request intertemporality Encompasses the use of multi-time-steps optimization and intertemporal constraints PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Power Gradient Constraints
1 participant