Refacto parameters #736
Merged
Refacto parameters #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godelaine
added
PR: waiting-for-review
…ty/farao-core into refacto_parameters
pet-mit
requested changes
Mar 6, 2023
...mmunity/farao/rao_api/json/deserializers/RangeActionsOptimizationParametersDeserializer.java
Outdated
Show resolved
Hide resolved
...com/farao_community/farao/rao_api/json/extensions/LoopFlowParametersExtensionSerializer.java
Outdated
Show resolved
Hide resolved
...com/farao_community/farao/rao_api/json/extensions/LoopFlowParametersExtensionSerializer.java
Outdated
Show resolved
Hide resolved
...ava/com/farao_community/farao/rao_api/json/extensions/MnecParametersExtensionSerializer.java
Outdated
Show resolved
Hide resolved
...ava/com/farao_community/farao/rao_api/json/extensions/MnecParametersExtensionSerializer.java
Outdated
Show resolved
Hide resolved
| import com.farao_community.farao.rao_api.parameters.extensions.LoopFlowParametersExtension; | ||
| import com.farao_community.farao.rao_api.parameters.extensions.LoopFlowParametersExtension.*; | ||
|
|
||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * @author Joris Mancini {@literal <joris.mancini at rte-france.com>} | ||
| */ | ||
| public class LoopFlowParameters { |
There was a problem hiding this comment.
is this class still necessary ? can't we replace its usages with LoopFlowParametersExtension ?
| if (Objects.isNull(relativeMarginParameters)) { | ||
| throw new FaraoException("No relative margins parameters were defined with objective function " + raoParameters.getObjectiveFunctionParameters().getObjectiveFunctionType()); | ||
| } | ||
| return new MaxMinRelativeMarginParameters(relativeMarginParameters.getPtdfSumLowerBound()); |
|
|
||
| /** | ||
| * @author Joris Mancini {@literal <joris.mancini at rte-france.com>} | ||
| */ | ||
| // TODO : classe doublon par rapport à la classe parametre ? |
| raoParameters.getPstPenaltyCost(), | ||
| raoParameters.getHvdcPenaltyCost(), | ||
| raoParameters.getInjectionRaPenaltyCost()); | ||
| return new RangeActionParameters(raoParameters.getRangeActionsOptimizationParameters().getPstModel(), |
| return new SolverParameters(raoParameters.getSolver(), | ||
| raoParameters.getRelativeMipGap(), | ||
| raoParameters.getSolverSpecificParameters()); | ||
| return new SolverParameters(raoParameters.getRangeActionsOptimizationParameters().getLinearOptimizationSolver().getSolver(), |
|
you have to remove sensi fallback mode from SystematicSensitivityInterface & SystematicSensitivityResult. |
pet-mit
requested changes
Mar 8, 2023
| @@ -96,6 +96,10 @@ public LoadFlowAndSensitivityParameters getLoadFlowAndSensitivityParameters() { | |||
| return loadFlowAndSensitivityParameters; | |||
| } | |||
|
|
|||
| public boolean hasExtension(RaoParameters raoParameters, Class classType) { | |||
There was a problem hiding this comment.
you don't need the raoParameters argument, use "this"
pet-mit
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refacto parameter handling in RAO : parameters are reorganized, optional/ not optional parameters are redefined. This induces profound changes in json serializer/deserializer classes. In addition to these changes, all parameters can now be loaded from a yaml file.
!! DO NOT DELETE BRANCH FOR THE MOMENT TO KEEP CONVERTER !!
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Rao parameters must be refactored according to new organisation
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)