-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various performance improvements #743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… store cnecs per contingency in sensi factor proiders to increase perf
…stead of the evaluator which was very wrong
…into performance_increase
pet-mit
requested changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if you had finished but I made some comments
data/crac/crac-impl/src/main/java/com/farao_community/farao/data/crac_impl/CracImpl.java
Outdated
Show resolved
Hide resolved
..._community/farao/search_tree_rao/commons/objective_function_evaluator/ObjectiveFunction.java
Outdated
Show resolved
Hide resolved
..._community/farao/search_tree_rao/commons/objective_function_evaluator/ObjectiveFunction.java
Show resolved
Hide resolved
...arao_community/farao/search_tree_rao/commons/objective_function_evaluator/CostEvaluator.java
Outdated
Show resolved
Hide resolved
.../farao/search_tree_rao/commons/objective_function_evaluator/ObjectiveFunctionResultImpl.java
Outdated
Show resolved
Hide resolved
.../farao/search_tree_rao/commons/objective_function_evaluator/ObjectiveFunctionResultImpl.java
Outdated
Show resolved
Hide resolved
...n/java/com/farao_community/farao/sensitivity_analysis/AbstractSimpleSensitivityProvider.java
Outdated
Show resolved
Hide resolved
pet-mit
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Performance improvement
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)