Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant parameters classes #750

Merged
merged 12 commits into from
Apr 12, 2023
Merged

Remove redundant parameters classes #750

merged 12 commits into from
Apr 12, 2023

Conversation

bqth29
Copy link
Collaborator

@bqth29 bqth29 commented Apr 7, 2023 •
edited
Loading

Context

Since February 2023 RAO parameters refactoring, some parameters classes are redundant (for example MnecParameters is now a copy of MnecParametersExtension).

It would make the code base a lot lighter to remove them.

Parameters classes to delete

  • MnecParameters → MnecParametersExtension
  • RangeActionParameters → RangeActionsOptimizationParameters
  • SolverParameters → RangeActionsOptimizationParameters.LinearOptimizationSolver
  • MaxMinRelativeMarginParameters → RelativeMarginsParametersExtension
  • LoopFlowParameters → LoopFlowParametersExtension

bqth29 added 2 commits April 7, 2023 15:21
@bqth29
All MnecParameters replaced by MnecParametersExtension + MnecParamete…
32b5b30 
…rs and MnecParametersTest files deletes
@bqth29
MnecParametersExtension's classes arguments moved to the empty constr…
c165ac3 
…uctor to avoid overwriting them when instantiating another one with the arguments constructor.
@bqth29 bqth29 added PR: WIP cleaning This issue or pull request only concerns improving the overall state of the code labels Apr 7, 2023
@bqth29 bqth29 added PR: waiting-for-review This PR is waiting to be reviewed and removed PR: WIP cleaning This issue or pull request only concerns improving the overall state of the code labels Apr 11, 2023
@bqth29 bqth29 changed the title [WIP] Remove redundant parameters classes Remove redundant parameters classes Apr 11, 2023
pet-mit
pet-mit requested changes Apr 12, 2023
View reviewed changes
...in/java/com/farao_community/farao/rao_api/parameters/RangeActionsOptimizationParameters.java Outdated Show resolved Hide resolved
...in/java/com/farao_community/farao/rao_api/parameters/RangeActionsOptimizationParameters.java Outdated Show resolved Hide resolved
...in/java/com/farao_community/farao/rao_api/parameters/RangeActionsOptimizationParameters.java Outdated Show resolved Hide resolved
...in/java/com/farao_community/farao/rao_api/parameters/RangeActionsOptimizationParameters.java Outdated Show resolved Hide resolved
...in/java/com/farao_community/farao/rao_api/parameters/RangeActionsOptimizationParameters.java Outdated Show resolved Hide resolved
...in/java/com/farao_community/farao/rao_api/parameters/extensions/MnecParametersExtension.java Outdated Show resolved Hide resolved
...in/java/com/farao_community/farao/rao_api/parameters/extensions/MnecParametersExtension.java Outdated Show resolved Hide resolved
...in/java/com/farao_community/farao/rao_api/parameters/extensions/MnecParametersExtension.java Outdated Show resolved Hide resolved
.../farao_community/farao/rao_api/parameters/extensions/RelativeMarginsParametersExtension.java Outdated Show resolved Hide resolved
.../farao_community/farao/rao_api/parameters/extensions/RelativeMarginsParametersExtension.java Outdated Show resolved Hide resolved
@bqth29 bqth29 requested a review from pet-mit April 12, 2023 09:21
@pet-mit pet-mit merged commit f8830f4 into master Apr 12, 2023
@pet-mit pet-mit deleted the removeRedundantParametersClasses branch April 12, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pet-mit pet-mit pet-mit approved these changes

Assignees
No one assigned
Labels
PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bqth29 @pet-mit