Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies and update Guava #770

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

murgeyseb
Copy link
Collaborator

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Code cleaning

Other information:
Remove unused dependencies and update Guava, following dependabot alert

Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
Copy link
Collaborator

@pet-mit pet-mit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all functional tests are OK, then it's OK for me!

@murgeyseb
Copy link
Collaborator Author

All functional tests are OK. Ready for merging on my side

@pet-mit pet-mit merged commit 368bcfb into master Jul 3, 2023
@pet-mit pet-mit deleted the remove_unused_dependencies branch July 3, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants