Csa 25 voltage ra in crac api #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # data/crac-io/crac-io-json/src/test/java/com/farao_community/farao/data/crac_io_json/JsonRetrocompatibilityTest.java
MartinBelthle
requested changes
Jul 31, 2023
...data/crac_creation/creator/cim/crac_creator/remedial_action/RemedialActionSeriesCreator.java
Outdated
Show resolved
Hide resolved
.../farao/data/crac_creation/creator/cim/parameters/JsonVoltageCnecsCreationParametersTest.java
Show resolved
Hide resolved
...on/src/main/java/com/farao_community/farao/data/crac_io_json/JsonSerializationConstants.java
Outdated
Show resolved
Hide resolved
.../farao_community/farao/data/crac_io_json/deserializers/HvdcRangeActionArrayDeserializer.java
Outdated
Show resolved
Hide resolved
...ao_community/farao/data/crac_io_json/deserializers/OnVoltageConstraintArrayDeserializer.java
Outdated
Show resolved
Hide resolved
...on/src/test/java/com/farao_community/farao/data/crac_io_json/JsonRetrocompatibilityTest.java
Outdated
Show resolved
Hide resolved
...rac-impl/src/main/java/com/farao_community/farao/data/crac_impl/OnVoltageConstraintImpl.java
Outdated
Show resolved
Hide resolved
...impl/src/test/java/com/farao_community/farao/data/crac_impl/OnVoltageConstraintImplTest.java
Outdated
Show resolved
Hide resolved
added 4 commits
August 1, 2023 13:26
…by MarthinBelthle
MartinBelthle
previously approved these changes
Aug 2, 2023
...src/test/java/com/farao_community/farao/data/crac_impl/OnVoltageConstraintAdderImplTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Test | ||
| void testOutageException() { | ||
| OnVoltageConstraintAdder adder = remedialActionAdder.newOnVoltageConstraintUsageRule().withInstant(Instant.OUTAGE).withVoltageCnec("cnec2stateCurativeContingency1"); |
There was a problem hiding this comment.
Same as previous comment, you can use OnVoltageConstraintAdder<NetworkActionAdder> adder
| if (instant.equals(Instant.PREVENTIVE)) { | ||
| owner.getCrac().addPreventiveState(); | ||
| } | ||
| // TODO: when Instant.AUTO will be handled by FARAO, consider adding some states in the CRAC here. |
There was a problem hiding this comment.
This TODO is not relevant anymore (left-over from 2021).
Could you remove it from this file and also these ones please: OnInstantAdderImpl, OnFlowConstraintAdderImpl, OnAngleConstraintAdderImpl ?
There was a problem hiding this comment.
In this file, in the method checkOnConstraintUsageRules, could you update the doc to add OnVoltageConstraint (line 84 to 86).
|
Once the comments have been resolved and the branch rebased with master, it can be merged 🙂 |
MartinBelthle
requested review from
MartinBelthle
and removed request for
MartinBelthle
Godelaine
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restUser story CSA-25
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Implement voltage remedial actions in crac API
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)