Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check physical parameters in RaoResult's isSecure #905

Merged
merged 34 commits into from
Jun 24, 2024
Merged

Check physical parameters in RaoResult's isSecure #905

merged 34 commits into from
Jun 24, 2024

Conversation

bqth29
Copy link
Collaborator

@bqth29 bqth29 commented Feb 28, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
Fixes #898

@bqth29
Check parameters
ec14273 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Merge branch 'main' into check_physical_parameters_in_is_secure
485986e
@bqth29
Check physical parameters in isSecure
2994c82 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@pet-mit pet-mit added the bug Something isn't working label Mar 22, 2024
bqth29 added 4 commits March 22, 2024 13:47
@bqth29
Merge branch 'main' into check_physical_parameters_in_is_secure
240db5e 
# Conflicts:
#	monitoring/angle-monitoring/src/main/java/com/powsybl/openrao/monitoring/anglemonitoring/RaoResultWithAngleMonitoring.java
#	monitoring/voltage-monitoring/src/main/java/com/powsybl/openrao/monitoring/voltagemonitoring/RaoResultWithVoltageMonitoring.java
@bqth29
Test Instant.min
5423aa5 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Exhaustive tests with all 2 types of CNECs
18ab9f2 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Merge branch 'main' into check_physical_parameters_in_is_secure
a5eee12
@bqth29 bqth29 requested a review from pet-mit March 22, 2024 14:30
@bqth29 bqth29 added the PR: waiting-for-review This PR is waiting to be reviewed label Mar 28, 2024
pet-mit
pet-mit requested changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@pet-mit pet-mit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall OK for me, but will break an actual behavior that is currently not tested.
I added some tests here: #966
We'll have to update this PR after the tests are merged

...c/main/java/com/powsybl/openrao/monitoring/anglemonitoring/RaoResultWithAngleMonitoring.java Outdated Show resolved Hide resolved
...c/main/java/com/powsybl/openrao/monitoring/anglemonitoring/RaoResultWithAngleMonitoring.java Outdated Show resolved Hide resolved
...in/java/com/powsybl/openrao/monitoring/voltagemonitoring/RaoResultWithVoltageMonitoring.java Outdated Show resolved Hide resolved
...in/java/com/powsybl/openrao/monitoring/voltagemonitoring/RaoResultWithVoltageMonitoring.java Outdated Show resolved Hide resolved
@pet-mit pet-mit added PR: waiting-for-correction This PR is waiting to be corrected by its author PR : pending-for-dependency-release This PR can't be merged until one dependency is updated PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) and removed PR: waiting-for-review This PR is waiting to be reviewed PR : pending-for-dependency-release This PR can't be merged until one dependency is updated labels Apr 11, 2024
@pet-mit
Copy link
Collaborator

pet-mit commented Apr 11, 2024

mustn't be merged before #966 (some corrections will then be needed here)

@pet-mit pet-mit removed the PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) label Apr 11, 2024
pet-mit and others added 3 commits April 12, 2024 09:33
@pet-mit
Change test 12.15.6
032152e 
Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
@bqth29
Rollb
9b1540a 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Merge branch 'main' into check_physical_parameters_in_is_secure
4b238f6
@pet-mit pet-mit added the PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) label Apr 22, 2024
@pet-mit
Copy link
Collaborator

pet-mit commented Apr 22, 2024

Mustn't be merge before #969 (test will need adaptation of the PR)

bqth29 and others added 10 commits April 22, 2024 11:32
@bqth29
Merge branch 'main' into check_physical_parameters_in_is_secure
d966b9a
@bqth29
Merge branch 'main' into change_swe_cne_test
7f1c8da
@bqth29
Merge branch 'change_swe_cne_test' into check_physical_parameters_in_…
49599f1 
…is_secure
@pet-mit
Merge branch 'main' into check_physical_parameters_in_is_secure
243d906
@bqth29
Merge branch 'check_physical_parameters_in_is_secure' of https://gith…
78e746e 
…ub.com/powsybl/powsybl-open-rao into check_physical_parameters_in_is_secure
@bqth29
Merge branch 'main' into check_physical_parameters_in_is_secure
0a0cb2b
@bqth29
Merge branch 'main' into check_physical_parameters_in_is_secure
27e892d
@bqth29
Fix test 12.15.6 + remove dupliacted code (now default RaoResul method)
88a0a2c 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Merge branch 'main' into check_physical_parameters_in_is_secure
f12c823
@pet-mit
Merge branch 'main' into check_physical_parameters_in_is_secure
1e23795
@pet-mit pet-mit added PR: waiting-for-review This PR is waiting to be reviewed and removed PR: waiting-for-correction This PR is waiting to be corrected by its author PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) labels Jun 20, 2024
pet-mit
pet-mit requested changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@pet-mit pet-mit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, can you try to improve coverage and reduce duplication?

...-exporter/swe-cne-exporter/src/main/java/com/powsybl/openrao/data/swecneexporter/SweCne.java Outdated Show resolved Hide resolved
@pet-mit pet-mit added the next-release This issue or pull request should be resolved before next release label Jun 20, 2024
bqth29 and others added 3 commits June 21, 2024 10:44
@bqth29 @pet-mit
Update data/result-exporter/swe-cne-exporter/src/main/java/com/powsyb…
30c682d 
…l/openrao/data/swecneexporter/SweCne.java

Co-authored-by: Peter Mitri <peter.mitri@rte-france.com>
Signed-off-by: Thomas Bouquet <63302082+bqth29@users.noreply.github.com>
@bqth29
Fix tests and remove duplicated code
cdc1968 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Promote default methods to Instant interface
d6f4a56 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29 bqth29 requested a review from pet-mit June 21, 2024 09:43
bqth29 and others added 2 commits June 24, 2024 17:01
@bqth29 @pet-mit
Update data/result-exporter/swe-cne-exporter/src/main/java/com/powsyb…
93b0b35 
…l/openrao/data/swecneexporter/SweCne.java

Co-authored-by: Peter Mitri <peter.mitri@rte-france.com>
Signed-off-by: Thomas Bouquet <63302082+bqth29@users.noreply.github.com>
@bqth29
Fix after comments
d3607c8 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@pet-mit pet-mit merged commit 1e320e8 into main Jun 24, 2024
10 checks passed
@pet-mit pet-mit deleted the check_physical_parameters_in_is_secure branch June 24, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pet-mit pet-mit pet-mit approved these changes

Assignees
No one assigned
Labels
bug Something isn't working next-release This issue or pull request should be resolved before next release PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In Flow RaoResult, when calling isSecure, ensure that it is called on FLOW parameter
2 participants
@bqth29 @pet-mit