Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network action compatibility filter #912

Merged
merged 25 commits into from
Jun 17, 2024
Merged

Conversation

bqth29
Copy link
Collaborator

@bqth29 bqth29 commented Mar 5, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
In the search tree, several network can be incompatible so if one was applied, it is useless to try to apply incompatible remedial actions because they would just override the currently applied remedial action's behaviour.

Two elementary actions are compatible if:

  • they have different types (ex: topo and injection)
  • they have the same type but different network elements
  • they have the same type and the same network elements + the same action type for topo / the same setpoint for injections

A network action NA1 is said to be included in another network action NA2 (NA1⊂NA2) if all the elementary actions of NA1 are elementary actions of NA2.

NA1 and NA2 are equal if all their elementary actions are equal (NA1⊂NA2 and NA2⊂NA1)

Two network actions are compatible if :

  • one is not included in the other
  • (thus they are different)
  • their elementary actions are compatible pairwise

otherwise they are incompatible.

A list of network actions is incompatible if at least two of there network actions are not compatible.

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
bqth29 added 3 commits March 6, 2024 10:50
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29 bqth29 requested a review from pet-mit March 6, 2024 11:14
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29 bqth29 requested a review from pet-mit March 6, 2024 14:11
bqth29 added 2 commits March 6, 2024 15:12
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29 bqth29 added the PR: waiting-for-review This PR is waiting to be reviewed label Mar 7, 2024
pet-mit
pet-mit previously approved these changes Mar 7, 2024
@pet-mit pet-mit added PR: waiting-for-correction This PR is waiting to be corrected by its author PR: waiting-for-info-reviewer This PR is waiting for information from its reviewer and removed PR: waiting-for-review This PR is waiting to be reviewed labels Apr 17, 2024
pet-mit
pet-mit previously approved these changes May 6, 2024
bqth29 added 3 commits June 17, 2024 10:44
# Conflicts:
#	ra-optimisation/search-tree-rao/src/main/java/com/powsybl/openrao/searchtreerao/searchtree/algorithms/SearchTreeBloomer.java
#	ra-optimisation/search-tree-rao/src/test/java/com/powsybl/openrao/searchtreerao/searchtree/algorithms/SearchTreeBloomerTest.java
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@phiedw phiedw merged commit d7d3772 into main Jun 17, 2024
10 checks passed
@phiedw phiedw deleted the coreCSA/remedial_action_compatibility branch June 17, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: waiting-for-correction This PR is waiting to be corrected by its author PR: waiting-for-info-reviewer This PR is waiting for information from its reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants