-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network action compatibility filter #912
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
pet-mit
requested changes
Mar 6, 2024
...test/java/com/powsybl/openrao/searchtreerao/searchtree/algorithms/SearchTreeBloomerTest.java
Outdated
Show resolved
Hide resolved
util/src/main/java/com/powsybl/openrao/util/NetworkActionsCompatibilityChecker.java
Outdated
Show resolved
Hide resolved
util/src/main/java/com/powsybl/openrao/util/NetworkActionsCompatibilityChecker.java
Outdated
Show resolved
Hide resolved
util/src/main/java/com/powsybl/openrao/util/NetworkActionsCompatibilityChecker.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
pet-mit
requested changes
Mar 6, 2024
data/crac/crac-impl/src/main/java/com/powsybl/openrao/data/cracimpl/NetworkActionImpl.java
Outdated
Show resolved
Hide resolved
util/src/main/java/com/powsybl/openrao/util/NetworkActionsCompatibilityChecker.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com> Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
pet-mit
previously approved these changes
Mar 7, 2024
phiedw
requested changes
Mar 21, 2024
data/crac/crac-impl/src/main/java/com/powsybl/openrao/data/cracimpl/SwitchPairImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
pet-mit
reviewed
Apr 11, 2024
data/crac/crac-impl/src/main/java/com/powsybl/openrao/data/cracimpl/SwitchPairImpl.java
Outdated
Show resolved
Hide resolved
pet-mit
added
PR: waiting-for-correction
This PR is waiting to be corrected by its author
PR: waiting-for-info-reviewer
This PR is waiting for information from its reviewer
and removed
PR: waiting-for-review
This PR is waiting to be reviewed
labels
Apr 17, 2024
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
pet-mit
previously approved these changes
May 6, 2024
…b.com/powsybl/powsybl-open-rao into coreCSA/remedial_action_compatibility
# Conflicts: # ra-optimisation/search-tree-rao/src/main/java/com/powsybl/openrao/searchtreerao/searchtree/algorithms/SearchTreeBloomer.java # ra-optimisation/search-tree-rao/src/test/java/com/powsybl/openrao/searchtreerao/searchtree/algorithms/SearchTreeBloomerTest.java
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
phiedw
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: waiting-for-correction
This PR is waiting to be corrected by its author
PR: waiting-for-info-reviewer
This PR is waiting for information from its reviewer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
In the search tree, several network can be incompatible so if one was applied, it is useless to try to apply incompatible remedial actions because they would just override the currently applied remedial action's behaviour.
Two elementary actions are compatible if:
A network action NA1 is said to be included in another network action NA2 (NA1⊂NA2) if all the elementary actions of NA1 are elementary actions of NA2.
NA1 and NA2 are equal if all their elementary actions are equal (NA1⊂NA2 and NA2⊂NA1)
Two network actions are compatible if :
otherwise they are incompatible.
A list of network actions is incompatible if at least two of there network actions are not compatible.