Do not export angle monitoring additional constraints if angle monitoring not run #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring not run Signed-off-by: SCHWITZGUEBEL Marc Ext <schwitzguebelmar@rte-france.com>
schwitzguebel
force-pushed
the
do-not-export-angle-monitoring-if-not-run
branch
from
04570d8 to
d55551e
Compare
|
please fill PR description |
pet-mit
added
bug
pet-mit
approved these changes
Apr 4, 2024
pet-mit
removed
the
PR: waiting-for-correction
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
…s do not exist (#957) Signed-off-by: belthlemar <martin.belthle@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not export additional constraints if angle monitoring not run.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
This PR changes the way SWE CNE is exported, removing additional onstraints if angle monitoring is not run.
What is the current behavior?
Currently, CNE exporter exports AdditionalConstraint for angle monitoring even when angle monitoring is not run (i.e. when first unsecure is due to RAO unsecure). Only Quantity element, within AdditionalConstraint, is not exported.
What is the new behavior (if this is a feature change)?
CNE exporter doesn't export AdditionalConstraint for angle monitoring when angle monitoring is not run (i.e. when first unsecure is due to RAO unsecure). Otherwise exports AdditionalConstraint with Quantity element.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: